https://bugzilla.redhat.com/show_bug.cgi?id=2316537



--- Comment #2 from Luya Tshimbalanga <[email protected]> ---
Quick review:
> Name:           hiprt
> Version:        2.4.6b6daf9
> Release:        %autorelease

According to https://docs.pagure.org/fedora-infra.rpmautospec/autorelease.html,
use the following for extraver case:

Version:        2.4
Release:        %autorelease -e 6b6daf9


Set ExclusiveArch: x86_64
as rocm series lacks support for both aarch64 and ppc64.

> %if %{with debug}
> %cmake_build --config DEBUG
> %else
> %cmake_build --config DELEASE
> %endif

Typing error for "DELEASE", it should be "RELEASE"

When rebuilding the SRPM through COPR, conflicts occurred with rocm-hip-devel
on other releases aside Fedora 40:
https://copr.fedorainfracloud.org/coprs/g/designsuite/blender/build/8109379/
It is not a problem tough for the current spec.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2316537

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202316537%23c2

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to