https://bugzilla.redhat.com/show_bug.cgi?id=2283681
Fabio Valentini <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #15 from Fabio Valentini <[email protected]> --- Sorry for the loooong delay here 😬 It looks like I somehow (not sure how) missed the fact that you posted an update. Package looks pretty good to me. I also ran a scratch build on rawhide to confirm that the package builds + tests pass on all architectures (they do 🥳). My only non-blocking RFE would be to exclude some files that are not useful in the package: - misc/: SVG images - scripts/: only useful for upstream development - clippy.toml: only useful for upstream development - rustfmt.toml: only useful for upstream development In particular, the scripts in scripts/ are executable bash scripts, and they cause the dependency generator to include /bin/bash and /bin/sh as dependencies of the -devel subpackage. Dropping the scripts/ folder should avoid this. === Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass (some dropped with justification) ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license files are included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version (*NOT* pre-release) filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2283681 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202283681%23c15 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
