https://bugzilla.redhat.com/show_bug.cgi?id=2316473



--- Comment #15 from Cristian Le <[email protected]> ---
> - removing g++ causes project cmake to refuse to configure

I was very confused to see the builds failing, and I debugged it locally. I
have missed that there is another usage of `project()`[1], you need to add
`LANGUAGES C` in there as well for the same reason.

> - waiting for upstreqa to cut a pr / commit/relese to fix the cmake file (I 
> am bad at cmake)

It is not required to wait for upstream for such patches.

About the new spec file, there is mostly one issue with:
> mv /usr/lib/libsafestring_shared.so* /usr/lib64/

This command would not work because the intermediate install directory is
`%{buildroot}/usr/lib64/...`, but also the install path is already set
correctly to `/usr/lib64`, so you don't need to worry about it. You can very
this using `mock /path/to/srpm` and then enter the mock environment with `mock
--shell` and you will find the stuff under `/build/BUILD...`

[1]:
https://github.com/intel/safestringlib/blob/master/unittests/CMakeLists.txt


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2316473

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202316473%23c15

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to