https://bugzilla.redhat.com/show_bug.cgi?id=2317585



--- Comment #31 from Jens Petersen <[email protected]> ---
It's looking pretty good.

I think source_url is redundant and should be removed.
Also is it really necessary explicitly to disable debug_package in the first
line?
I think no debuginfo package is generated for noarch anyway.

(Also there is no review requirement for the package so build for all current
releases,
so the f39 patch could just be excluded from the review,
but sure it is good to provide an upstream reference if you want to have the
patch. :)


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2317585

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202317585%23c31

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to