https://bugzilla.redhat.com/show_bug.cgi?id=2274359
Yaakov Selkowitz <yselk...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Flags| |fedora-review?
Assignee|nob...@fedoraproject.org |yselk...@redhat.com
--- Comment #5 from Yaakov Selkowitz <yselk...@redhat.com> ---
A few points:
* Is anything actually under the CC-BY-SA-4.0 license?
* QML import dependencies need to be added as Requires
* I'd move the Requires: hicolor-icon-theme after all the BuildRequires for
readability.
* %files should include %doc README.md
* The changelog entry needs to be updated.
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2274359
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202274359%23c5
--
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
