https://bugzilla.redhat.com/show_bug.cgi?id=2331506



--- Comment #2 from Jeremy Newton <[email protected]> ---
This should be a noarch package. I'm assuming gcc-c++ is required because cmake
is silly.

Please use the workaround we have in rocprim to install the cmake into datadir
instead of libdir:
https://src.fedoraproject.org/rpms/rocprim/blob/rawhide/f/rocprim.spec#_80

This can be dropped when you make it noarch:
> # there is no debug package
> %global debug_package %{nil}

Pet peeve :
> %dir %{_includedir}/%{name}
> %{_includedir}/%{name}/*.h
is easier to put as
> %{_includedir}/%{name}


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2331506

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202331506%23c2

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to