https://bugzilla.redhat.com/show_bug.cgi?id=2333030



--- Comment #10 from Jonathan Steffan <[email protected]> ---
[!]: Package is not known to require an ExcludeArch tag.

Noting that we are excluding 32bit.


[!]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     python3-symengine , python3-symengine-tests

Update the Requires to match.


[!]: Packages should try to preserve timestamps of original installed
     files.

unzip/zip will preserve.
We need to add -a or -p to the cp commands.


python3-symengine.x86_64: W: python-bytecode-without-source
/usr/lib64/python3.13/site-packages/symengine/__pycache__/test_utilities.cpython-313.opt-1.pyc
python3-symengine.x86_64: W: python-bytecode-without-source
/usr/lib64/python3.13/site-packages/symengine/__pycache__/test_utilities.cpython-313.pyc

We need to ship the source of these.


[!]: Development files must be in a -devel package
python3-symengine.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/python3.13/site-packages/symengine/lib/pywrapper.h

https://docs.fedoraproject.org/en-US/packaging-guidelines/#_exceptions_3 seems
to indicate we need to put this one file in a -devel subpackage? If not, maybe
we need to delete it?

python-symengine.src: E: description-line-too-long Python wrappers to the C++
library SymEngine, a fast C++ symbolic manipulation library.
python3-symengine.x86_64: E: description-line-too-long Python wrappers to the
C++ library SymEngine, a fast C++ symbolic manipulation library.
python3-symengine-tests.x86_64: E: description-line-too-long Python wrappers to
the C++ library SymEngine, a fast C++ symbolic manipulation library.

Let's just change this to "Python wrappers to the C++ library SymEngine" to
make this happy.


Issues:
=======
- Header files in -devel subpackage, if present.
  Note: python3-symengine : /usr/lib64/python3.13/site-
  packages/symengine/lib/pywrapper.h
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/#_devel_packages

[!]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.

Unversioned so-files
--------------------
python3-symengine:
/usr/lib64/python3.13/site-packages/symengine/lib/symengine_wrapper.cpython-313-x86_64-linux-gnu.so
python3-symengine.x86_64: E: invalid-soname
/usr/lib64/python3.13/site-packages/symengine/lib/symengine_wrapper.cpython-313-x86_64-linux-gnu.so
symengine_wrapper.cpython-313-x86_64-linux-gnu.so

Per
https://docs.fedoraproject.org/en-US/packaging-guidelines/Unversioned_shared_objects/
this is okay.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2333030

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202333030%23c10

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to