https://bugzilla.redhat.com/show_bug.cgi?id=2335013
--- Comment #8 from Gwyn Ciesla <gw...@protonmail.com> --- You're very welcome! Well, both methods work, but I tend towards patching for two reasons. One, if the change is no longer needed, you won't have a spurious sed command lingering forever. Two, if the change needs adjusting, the build will break, and you'll know and can refactor the patch to make sure it's still appropriate, etc. The only time I really do changes to files in the spec is if it's a change I know will always be needed, especially if a patch would require constant updating due to a date string or something. The above is for file changes. For directories that need removing, do that in the spec. Make sense? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2335013 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202335013%23c8 -- _______________________________________________ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
