https://bugzilla.redhat.com/show_bug.cgi?id=2328984



--- Comment #3 from Peter Lemenkov <[email protected]> ---
(In reply to Benson Muite from comment #2)

> Comments:
> a) Data is under UNICODE 3.0 which is permitted.  If it is not packaged,
> probably,
> the unicode license can be removed.  Nonetheless, running the unicode tests
> seems useful.

Switched to tarball from GitHub which does contains everything we need for
testing.

> As the PyPi source does not have the tests or test data, maybe it is worth
> raising an
> issue upstream to tag the next release so they can be included?

I'll do.

> b) Tests should be run with %tox not %pytest

Done.

> c) Can a license breakdown be added to the spec? My understanding is that
> only the
> data is under the Unicode license, however maybe upstream can clarify.  This
> is the only
> blocking point.

Added licensing breakdown.

Spec URL: https://peter.fedorapeople.org/packages/python-pyunormalize.spec
SRPM URL:
https://peter.fedorapeople.org/packages/python-pyunormalize-16.0.0-1.fc41.src.rpm

Koji scratch build for Rawhide:

* https://koji.fedoraproject.org/koji/taskinfo?taskID=127643369


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2328984

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202328984%23c3

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to