https://bugzilla.redhat.com/show_bug.cgi?id=2334700



--- Comment #14 from Simone Caronni <[email protected]> ---
(In reply to Jonathan Steffan from comment #13)
> [!]: Patches link to upstream bugs/comments/lists or are otherwise
>      justified.
> 
> Publish our patch upstream and link to it.

Will do as soon as I get it working.

> [!]: License file installed when any subpackage combination is installed.
> [!]: Fully versioned dependency in subpackages if applicable.
>      Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
>      python3-cnkalman
> 
> Adding this BR fixes both issues.

Which BR?...

> [!]: Package is not known to require an ExcludeArch tag.
> [!]: Package should compile and build into binary rpms on all supported
>      architectures.
> 
> Package fails to build on 32bit.
> https://koji.fedoraproject.org/koji/taskinfo?taskID=127741108

Yes, this was already fixed here:
https://bugzilla.redhat.com/show_bug.cgi?id=2334700#c5

> [!]: Package complies to the Packaging Guidelines
> [!]: Package meets the Packaging Guidelines::Python
> 
> Why can't we use the files automation? If we can't, be more explicit:

This was already fixed here:
https://bugzilla.redhat.com/show_bug.cgi?id=2334700#c5
There are 15 lines of comments about it, have you checked the SPEC file?

> %files -n python3-%{name}
> %{python3_sitearch}/%{name}/
> %{python3_sitearch}/%{name}/filter.cpython-313-x86_64-linux-gnu.so
> 
> Also, update the main %files for the DSO to be:
> 
> %{_libdir}/lib%{name}.so.0{,.*}

Fixed.

> [!]: %check is present and all tests pass.
> 
> Add %check but disable by default.
> 
> cnkalman.x86_64: E: undefined-non-weak-symbol /usr/lib64/libcnkalman.so.0
> cnSetZero     (/usr/lib64/libcnkalman.so.0)
> 
> I'm not sure what to do here. This seems like an upsteam bug and I know is
> also impacting testing.

This needs to be fixed, it also throws the same errors as in the test binary in
libsurvive. I'm on it.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2334700

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202334700%23c14

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to