Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=688316

--- Comment #2 from Chris Lalancette <[email protected]> 2011-03-21 08:43:25 
EDT ---
Thanks for the review!

Based on your review, I've gone back and looked at the upstream for this
package.  When I initially generated the gem, I did it out of the git
repository for the package, so I got version 1.5.0 of the package.  However,
looking at the correct place to download the package from (rubyforge.org), I
see that only 1.4.3 has been released there so far.  So what I've done is to
fix up the spec file via your recommendation, and downgrade the version of the
package to 1.4.3 so that the package meets the rubygem guidelines.

The new version is here:

Spec URL:
http://people.redhat.com/clalance/rubygem-logging/rubygem-logging.spec
SRPM URL:
http://people.redhat.com/clalance/rubygem-logging/rubygem-logging-1.4.3-1.fc14.src.rpm

Out out of curiosity, how did you generate the report above?  It would be
useful for me when I do package reviews.

Thanks again,
Chris Lalancette

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to