https://bugzilla.redhat.com/show_bug.cgi?id=2350109
Bug ID: 2350109
Summary: Review Request: systemd-cron - systemd-generator
implementing cronie and anacron
Product: Fedora
Version: rawhide
Hardware: All
OS: Linux
Status: NEW
Component: Package Review
Severity: medium
Assignee: [email protected]
Reporter: [email protected]
QA Contact: [email protected]
CC: [email protected]
Target Milestone: ---
Classification: Fedora
Spec URL: [The specfile is written below]
SRPM URL: [The SRPM is available in below linked copr]
Description: A systemd generator which generates service-timer unit pairs from
cronjobs.
Fedora Account System Username: pramodvu1502
Copr with the package:
https://copr.fedorainfracloud.org/coprs/pramodvu1502/systemd-cron/
Upstream repo:
https://github.com./systemd-cron/systemd-cron
The exact specfile `systemd-cron.spec` for quick reference:
```
# https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd
#
https://github.com/systemd/systemd/blob/42911a567dc22c3115fb3ee3c56a7dcfb034f102/src/core/macros.systemd.in
# "If your package includes one or more systemd units that need
# to be enabled by default on package installation,
# they must be covered by the Fedora preset policy."
Name: systemd-cron
Version: 2.5.1
Release: 1
License: MIT
Summary: systemd generator to provide cron daemon & anacron
functionality
Url: https://github.com/systemd-cron/systemd-cron/
Group: System Environment/Base
Source:
https://github.com/systemd-cron/systemd-cron/archive/v%{version}.tar.gz
Provides: cronie
Provides: cronie-anacron
Conflicts: cronie
Conflicts: cronie-anacron
BuildRoot: %{_tmppath}/%{name}-%{version}-build
Requires: crontabs
Requires: systemd
BuildRequires: g++
BuildRequires: libmd-devel
%description
Provides a systemd generator to run cron jobs in /etc/cron.hourly cron.daily
cron.weekly and cron.monthly directories, crontab etc..
without having cron or anacron installed.
%pre
touch /run/crond.reboot
touch /run/crond.bootdir
%preun
%systemd_preun cron.target
%post
# XXX this macro doesn't seems to do anything
%systemd_post cron.target
if [ $1 -eq 1 ] ; then
systemctl daemon-reload
systemctl enable cron.target
systemctl start cron.target
fi
%postun
%systemd_postun_with_restart cron.target
%prep
%setup -q
%build
./configure \
--enable-runparts=no \
--enable-minutely=yes \
--enable-quarterly=yes \
--enable-semi_annually=yes
# Disabled run-parts i.e. static single units for each granuarity level.
# Instead opting to use only systemd-generators
# run-parts override the generator when installed
# Also enabled all disabled-by-default granularity levels
make
%install
make DESTDIR=$RPM_BUILD_ROOT install
mkdir -p $RPM_BUILD_ROOT/var/spool/cron
mkdir -p $RPM_BUILD_ROOT/etc/cron.d/
mkdir -p $RPM_BUILD_ROOT/etc/cron.weekly/
# Cleanup cronjob not included as systemd timer for it exists.
# cp contrib/systemd-cron.cron.weekly
$RPM_BUILD_ROOT/etc/cron.weekly/systemd-cron
mkdir -p $RPM_BUILD_ROOT/usr/lib/systemd/system-preset/
echo 'enable cron.target' >
$RPM_BUILD_ROOT/usr/lib/systemd/system-preset/50-systemd-cron.preset
%files
%license LICENSE
%doc README.md CHANGELOG
%dir /etc/cron.d/
%dir /etc/cron.weekly/
%dir /var/spool/cron
/usr/lib/sysusers.d/systemd-cron.conf
/usr/bin/crontab
/usr/libexec/systemd-cron/mail_for_job
/usr/libexec/systemd-cron/boot_delay
/usr/libexec/systemd-cron/remove_stale_stamps
/usr/libexec/systemd-cron/crontab_setgid
/usr/lib/systemd/system-generators/systemd-crontab-generator
/usr/lib/systemd/system-preset/50-systemd-cron.preset
/usr/lib/systemd/system/cron.target
/usr/lib/systemd/system/cron-update.path
/usr/lib/systemd/system/cron-update.service
/usr/lib/systemd/system/[email protected]
/usr/lib/systemd/system/systemd-cron-cleaner.service
/usr/lib/systemd/system/systemd-cron-cleaner.timer
%{_mandir}/man1/crontab.*
%{_mandir}/man5/crontab.*
%{_mandir}/man5/anacrontab.*
%{_mandir}/man7/systemd.cron.*
%{_mandir}/man8/systemd-crontab-generator.*
```
The specfile isn't yet upstreamed, and the maintainer hasn't yet replied to me
on it. [I just package systemd-cron for fedora, am not the actual maintainer of
systemd-cron; have no commit access yet]
Due to this, till the situation improves, the specfile is hand-hardcoded into
the "Custom build script" option in the copr. I will change it to git at the
earliest once the specfile is upstreamed into the systemd-cron git repo.
However, I believe that this is sufficient for the initial testing and
reviewing, until it gets upstreamed.
It successfully builds on the copr infrastructure for fedora based distros, and
I have manually tried those packages; They work perfectly as intended.
I want to maintain the fedora package for the `systemd-cron` project, and want
it to be enrolled into the fedora repos.
Yes, this is my 1st package on fedora.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2350109
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202350109%23c0
--
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
