https://bugzilla.redhat.com/show_bug.cgi?id=2350914



--- Comment #4 from Neal Gompa <[email protected]> ---
Review notes:

* Package follows Fedora packaging guidelines
* Package builds and installs correctly
* Package licensing is mostly correct and provided license files are installed
  + I see code from zlib, wpa_supplicant, and some other vendored projects in
here with licenses other than GPL-2.0-only. These need to be enumerated in the
license tag and bundled provides where relevant.
* No serious issues from rpmlint

Please address the licensing related issues and then we should be good to go.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2350914

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202350914%23c4

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to