https://bugzilla.redhat.com/show_bug.cgi?id=2344133
Fabio Valentini <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|[email protected] |[email protected] Status|NEW |POST CC| |[email protected] Flags| |fedora-review+ --- Comment #2 from Fabio Valentini <[email protected]> --- Looks good to me. Note that there was a 0.23.5 release in the meantime. Since there are no code changes, only string changes in comments and metadata, I won't block this review on that. GStreamer 1.26 has only just today landed in rawhide - you can add the v1_26 feature back to the package if you only plan to target Rawhide, otherwise I would recommend to import it *without* that so you can merge it back to f42 / f41 branches without having the branches diverge unnecessarily (that will come soon enough ...) === Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide 🫤 test suite is run and all unit tests pass (disabled with justification) 🫤 latest version of the crate is packaged (latest is 0.23.5, current is 0.23.4) ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-$crate - set bugzilla assignee overrides to @rust-sig (optional) -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2344133 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202344133%23c2 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
