https://bugzilla.redhat.com/show_bug.cgi?id=2352883



--- Comment #2 from Dominik 'Rathann' Mierzejewski <[email protected]> ---
> rm -fr %{_vpath_builddir}/examples/*.p

Please change that to rm -rv or rm -r. Using -f makes it succeed even if there
are no files to delete.

> %files samples
> %{_bindir}/*

What's the reason for the wildcard?
Are there too many to list?
Does the list change between releases?

>   -D tests=enabled

While the option is there:
https://github.com/sammycage/plutosvg/blob/master/meson_options.txt#L2
it doesn't seem to be used anywhere, so there's little point in enabling it.

Spec file looks good otherwise.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2352883

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202352883%23c2

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to