https://bugzilla.redhat.com/show_bug.cgi?id=2356145
Michal Josef Spacek <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?([email protected] | |om) --- Comment #1 from Michal Josef Spacek <[email protected]> --- @[email protected] Some nits * The dependency on coreutils is not needed. Sure? * There are two "NO_PACKLIST=1" * Regarding the module versions and Perl version used. There are >>use v5.20;<<, >>"Crypt::URandom" => "0.40"<< and >>"Test::Exception" => "0.43"<<. Isn't it better to present them in the spec file? I understand that we don't hit this issue, but for common use, it could be better. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2356145 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202356145%23c1 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
