https://bugzilla.redhat.com/show_bug.cgi?id=2358970
Fabio Valentini <decatho...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Assignee|nob...@fedoraproject.org |decatho...@gmail.com
CC| |decatho...@gmail.com
Flags| |fedora-review?
--- Comment #11 from Fabio Valentini <decatho...@gmail.com> ---
Some issues in the package as-is:
> # * - dynamic::type_sizes This test uses std::mem::size_of which is
> inconsistent
> # on i686
This might be indicative of a real problem (or not), would be good to check
with upstream.
> LICENSE-APACHE
> LICENSE-MIT
These files don't contain actual license texts, but the literal strings
"../LICENSE-APACHE" and "../LICENSE-MIT", respectively.
Looks like the current version was published on a Windows system without
working symbolic links (or the files are actually messed up in git too, I
haven't checked).
> # Broken test because tests.rs is not in crate
> sed -i '/#\[cfg(test)\]/,/mod tests/d' src/descriptor/mod.rs
This is unfortunate, but likely not avoidable.
I usually recommend to upstream projects to at least include all the files to
make tests *compile* (if not run).
If tests at least *compile* you can "--skip" as appropriate. But if they don't
even compile, it's a lot more annoying.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2358970
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202358970%23c11
--
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
