https://bugzilla.redhat.com/show_bug.cgi?id=2346041



--- Comment #39 from Michel Lind <[email protected]> ---
(In reply to Sergio Basto from comment #37)
> I replied to him in comment #29
> 
> I copied license and description for his spec , I also verified that we
> can't use his LOCAL_FLAGS="%{optflags}" , it will remove definitions from
> some builds,  specifically -DZ7_EXTRACT_ONLY -DZ7_NO_READ_FROM_CODER
> -DZ7_SFX from CPP/7zip/Bundles/SFXCon , what's more to sort out ? 
> 
you can always add to LOCAL_FLAGS, see my 7z build

%make_build %make_opts LOCAL_FLAGS="%{optflags} -DZ7_EXTERNAL_CODECS" -C
CPP/7zip/UI/Console/

> 
> - clean source and remove Rar references applied with clean_7zip.sh
> - Added comments about origin of *.sh, *.1 and fix-compatib-with-p7zip.patch
> - Fixed provides
> - Enabled debug. I achieved even a better way to inject CFLAGS  
> 
> I think all is fixed since 2025-04-25 and package is ready and Michel is
> welcome to maintain the package

I'll let the reviewers figure out what to do, I think personally starting with
a spec that has no borrowing from any other distribution is probably better.
But either way the only reason I'm even proposing a spec is because we need
7zip available one way or another (since branching the really old p7zip for
EPEL 10 is obviously not a good solution)


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2346041

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202346041%23c39

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to