https://bugzilla.redhat.com/show_bug.cgi?id=2361600



--- Comment #5 from Cole Robinson <[email protected]> ---
Some other bits:

+ if the dump_igvm tool is just a helper tool, I think it should go in a
`NAME-tools` package

+ rust-bitfield-struct is at version 0.11 in Fedora, so you need to adjust your
version patch. I confirmed it's still building with that 

+ take a look at /usr/lib/rpm/macros.d/macros.cargo %__cargo macro. I think you
want to export `CARGO_HOME=.cargo` and `RUSTFLAGS='%{build_rustflags}'` too so
that trickles down to cargo called by the Makefile.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2361600

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202361600%23c5

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to