https://bugzilla.redhat.com/show_bug.cgi?id=2373034



--- Comment #6 from Benson Muite <[email protected]> ---
(In reply to Fabio Valentini from comment #5)
> > Comments:
> > a) Raised issue about licensing upstream:
> > https://github.com/elementary/capnet-assist/issues/132
> 
> Thanks for that!

Ok, hopefully will be answered soon.

> 
> > b) svg icon should just go into 
> > %{_datadir}/icons/hicolor/scalable/apps/%{appname}.svg
> > Can the other copies be removed?
> 
> Why? Size-specific icons can use the SVG format too, this is perfectly valid.

Seems like not good use of space. Not a blocker though.

> 
> > c) To get moldovian directory ownership fixed,
> > https://src.fedoraproject.org/rpms/filesystem/pull-request/28
> > needs to be merged
> 
> Yes, this has been an issue for literally a decade, I don't think this
> should block the package review.
> 
> > d) May want to put the language translation files in a noarch
> > subpackage.
> 
> Why? That would be quite unusual and overkill for a normal GUI app with very
> small-sized translations ...

Ok.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2373034

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202373034%23c6

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to