Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=691541

--- Comment #3 from Omair Majid <[email protected]> 2011-03-29 10:41:13 EDT ---
Thanks for the fixes. Some more minor issues.

- archbuild, archinstall: are these macros used anywhere? Or is this some
rpm-internal magic?

- Why is the main package exclusive arch? Is it because openjdk is exclusive
arch?

- Javadoc subpackage needs to be built as noarch [1]. Since it does not depend
on the main package, it needs its own copy of COPYING [2].

- %files javadoc uses %{datadir}/javadoc but configure uses %{_javadocdir}

[1] http://fedoraproject.org/wiki/Packaging/Java#Javadoc_installation
[2]
http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#Subpackage_Licensing

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to