https://bugzilla.redhat.com/show_bug.cgi?id=2376217
--- Comment #1 from Steve Traylen <steve.tray...@cern.ch> ---
Just reading the .spec file quick:
Requires(post): systemd
Requires(preun): systemd
Requires(postun): systemd
This is probably meant to be:
BuildRequires: systemd-rpm-macros
You just need enough so the macros can be expanded.
All the "%{?_isa}" can go.
There is a macro for /usr/lib/systemd/system/ - %{_unitdir} I think.
I'm not of fan of all the
# Older versions of this package had opposite symlinks for vault compatibility,
# and rpm needs help to handle that.
and similar - this package was never in Fedora so its simply not this packages
problem to fix previous state. This gets rid if all that was it running stuff.
Fedora
package do not do this.
For the user/group add stuff please use a sysusers.d record -
https://docs.fedoraproject.org/en-US/packaging-guidelines/UsersAndGroups/
All the bundling is hard for me however I know this has been relaxed a lot
more with golang. This probably needs a real go packager to look at this.
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2376217
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202376217%23c1
--
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
