https://bugzilla.redhat.com/show_bug.cgi?id=2358552
Cristian Le <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? CC| |[email protected] Assignee|[email protected] |[email protected] --- Comment #5 from Cristian Le <[email protected]> --- Looks fine overall, just 3 issues: - I see that you found that the package uses MIT licensed code but it is not attributed correctly. But I do not see a relevant upstream issue opened, could you do that. - What's the deal with `esaxx.cpp`? That thing seems to have a whole other implementation that is commented. - `data/eighty.txt` seems to use a file from Project Gutenberg. Can you check if that is allowed to be packaged? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2358552 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202358552%23c5 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
