https://bugzilla.redhat.com/show_bug.cgi?id=2346429

Xavier Bachelot <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #1 from Xavier Bachelot <[email protected]> ---
Hi Chris,

Some notes after a first look at this review.

- _fixperms macro uses chmod so BR: coreutils is missing

- in files section
"""
%dir %{perl_vendorarch}/auto/Net
%{perl_vendorarch}/auto/Net/LibNFS*
%dir %{perl_vendorarch}/Net
%{perl_vendorarch}/Net/LibNFS*
"""
  could be simplified to
"""
%{perl_vendorarch}/auto/Net/
%{perl_vendorarch}/Net/
"""

- It's is usually preferred to reference the tarball by module rather than by
author.
  Source0 could be changed to use
https://www.cpan.org/modules/by-module/Net/Net-LibNFS-%{version}.tar.gz

- Package fails to build for Rawhide and F42, but succeeds with F41
  Likely induced by gcc 15 but possibly also libnfs update from libnfs 5 to
libnfs 6

Regards,
Xavier


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2346429

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202346429%23c1

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to