https://bugzilla.redhat.com/show_bug.cgi?id=2383530
--- Comment #1 from Fabio Valentini <[email protected]> --- Initial review ============== 1. These should both be unused / noops in this kind of package, please remove them: > %global cargo_install_lib 0 > %global crate grass 2. Use the standard / documented SourceURL format for GitHub sources please: > Source: > https://github.com/connorskees/grass/archive/refs/tags/%{version}/%{crate}-%{version}.tar.gz > %autosetup -n %{crate}-%{version} -p1 becomes > Source: > https://github.com/connorskees/grass/archive/%{version}/grass-%{version}.tar.gz > %autosetup -n grass-%{version} -p1 3. Don't "cd" into some subdirectory, it shouldn't be necessary: > %generate_buildrequires > cd crates/lib > %cargo_generate_buildrequires becomes > %generate_buildrequires > %cargo_generate_buildrequires etc. (and analogue changes in the other scriptlets and in the %files list) Not sure why you thought this was necessary - it should be a noop and just looks confusing. Running cargo at the top-level (i.e. where the top-level Cargo.toml with the workspace definition is) should work just fine. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2383530 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202383530%23c1 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
