https://bugzilla.redhat.com/show_bug.cgi?id=2330850



--- Comment #23 from Benson Muite <[email protected]> ---
Comments:
a) Please change the name of
67-0-anir-samaano-fonts.conf
to
67-anir-samaano-fonts.conf
b) Consider making releases that are tagged, see:
https://docs.gitlab.com/user/project/releases/
https://docs.gitlab.com/user/project/repository/tags/

c) If you will not be using a new release, for the url of the fonts
configuration file, please use
something that references the specific commit, for example
https://gitlab.com/mitradranirban/anir-samaano-fonts/-/raw/521150de7faeb311b5cd17592878d5e9901cad01/67-0-anir-samaano-fonts.conf

If you will be using a new release, the font configuration file is part of the
repository, so
does not need a separate download, so

Source1:
https://gitlab.com/mitradranirban/anir-samaano-fonts/-/raw/main/67-0-anir-samaano-fonts.conf

can be removed and
%global fontconfs        %{SOURCE1}
can be changed to
%global fontconfs        67-anir-samaano-fonts.conf

d) When installed, in typical applications, the variable font only shows up as
the bold variant.  Maybe more metadata is needed?

If there are two subpackages, should they share the same file
67-anir-samaano-fonts.conf or have different ones?


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2330850

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202330850%23c23

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to