https://bugzilla.redhat.com/show_bug.cgi?id=2388375
--- Comment #47 from Akiyoshi Kurita <[email protected]> --- Spec URL: https://raw.githubusercontent.com/redadmin-k/gshogi-fedora44/refs/heads/main/gshogi.spec SRPM URL: https://github.com/redadmin-k/gshogi-fedora44/raw/refs/heads/main/gshogi-0.5.1^20250818.git7c4bd90-3.fc44.src.rpm Dear Cristian, Thank you again for your continued guidance. I’ve gone through your notes (esp. Comment #35) and addressed them. Summary of changes and current status: • desktop-file-validate: moved back to %check as requested. ✅ • sed vs patch: replaced sed with a proper patch (Patch0: 0001-drop-data_files-and_ez_setup.patch) that removes ez_setup.py and data_files usage from setup.py. ✅ • %pyproject_buildrequires: now using %pyproject_buildrequires -r to resolve build requirements from pyproject/setup definitions. ✅ • %pyproject_save_files -l: in use; license files are captured via dist-info. ✅ • %pyproject_check_import: added `%pyproject_check_import gshogi` to %check. ✅ • Snapshot versioning: using the recommended snapshot format `0.5.1^20250818.git7c4bd90`. ✅ • Provides: bundled(gnushogi): present, as the engine sources are bundled. ✅ • desktop-file-validate during install: no longer done there; it only runs in %check. ✅ Build deps minimization: – I kept the build-time dependencies minimal and treated GI/GTK as runtime deps. If you prefer further trimming (e.g., dropping gtk3-devel if superfluous on your side), I’m happy to adjust immediately. (Non-blocking) Copr builds succeed. The only recurring note is the known “Upstream MD5sum check error” with GitHub auto-generated tarballs, which is a false positive per Fedora packaging guidelines discussion around SourceURL/tarball reproducibility. Blocks already includes FE-NEEDSPONSOR as I’m a new contributor. If anything else needs tweaking, I’ll fix it promptly. Many thanks again for your time and review. Best regards, Akiyoshi Kurita -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2388375 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202388375%23c47 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
