https://bugzilla.redhat.com/show_bug.cgi?id=2388645
--- Comment #5 from Neal Gompa <[email protected]> --- Initial spec review: > Source: > https://gitlab.gnome.org/guidog/stevia/-/archive/v%{version_no_tilde > _}/%{name}-v%{version_no_tilde _}.tar.gz This can be simplified to "%{url}/-/archive/v%{version_no_tilde _}/%{name}-v%{version_no_tilde _}.tar.gz" (Also, TIL about %version_no_tilde args.) > ExcludeArch: i686 This should use %{ix86} macro. > BuildRequires: /usr/bin/xvfb-run Please use /usr/bin/xwfb-run instead. > Conflicts: squeekboard Why does it conflict? > %setup -q -n %{name}-v%{version_no_tilde _} Please use "%autosetup -p1" here, so that if patches need to be applied, they will be. > %meson -Dman=true This should move to %conf section above %build. > LC_ALL=C.UTF-8 xvfb-run sh <<'SH' Use xwfb-run here. > %{_mandir}/man1/phosh-osk-stevia.1.gz Use "1*" instead, since ".gz" is not guaranteed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2388645 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202388645%23c5 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
