https://bugzilla.redhat.com/show_bug.cgi?id=2364617

Sandro <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #6 from Sandro <[email protected]> ---
First of all, thanks for trying to bring back Apostrophe to the Fedora repos.
I've been unable to find a replacement that suits my needs since the package
was retired.

(In reply to Alexander Lent from comment #3)
> While it's true that the codebase between 3.0 and 3.2 has been pretty
> stagnant, (though it seems like there's been a bit more activity since the
> 3.2 release,) my understanding of the previous reports is that most of the
> crashes were due to calling functions that didn't exist in  upstream
> libspelling and gtksouceview5, which have now been upstreamed into recent
> versions of those libraries.

As of version 3.3 the upstream patches for libspelling and gtksourceview have
been dropped. I've tried a local build and it worked well with the system
installed libraries. I was unable to reproduce bug 2291412.

(In reply to Yaakov Selkowitz from comment #4)
> I'd prefer to see less wildcards in %check and %files, but otherwise I don't
> see any blatantly obvious problems in the spec file.

For the .desktop and .xml files you can simply replace the asterisk with the
already defined macro %{appid}. You may also want to run some tests in %check
with:

%{py3_test_envvars} %python3 tests/test_regex_commonmark.py

Could you update to version 3.3? I'd be willing to take a shot at the review
since I'd really like to see this package back in Fedora.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2364617

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202364617%23c6

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to