https://bugzilla.redhat.com/show_bug.cgi?id=2358553
--- Comment #7 from Gordon Messmer <[email protected]> --- ... building indicatif == 0.17 would also require an additional rust-console package, so that doesn't seem like a good option. Bumping the indicatif dep is probably the best option: https://github.com/huggingface/tokenizers/pull/1867 For the most part, this looks OK, but there are several prerequisites. Fedora has rust-fancy-regex 0.13, but this package needs 0.14. Fedora does not yet have rust-hf-hub, which this package will require. Fedora has rust-getrandom, but not the wasm_js feature that this package requires. However, all of those prerequisites are necessitated by optional features of this package. If we build only the default feature set, none of them should be a concern. I've built a variant of this package that drops optional features, and bumps the indicatif dep version, and that should pass review except for a few duplicate files: Wrote: /builddir/build/SRPMS/rust-tokenizers-0.21.4-1.fc43.src.rpm Wrote: /builddir/build/RPMS/rust-tokenizers+indicatif-devel-0.21.4-1.fc43.noarch.rpm Wrote: /builddir/build/RPMS/rust-tokenizers+esaxx_fast-devel-0.21.4-1.fc43.noarch.rpm Wrote: /builddir/build/RPMS/rust-tokenizers+default-devel-0.21.4-1.fc43.noarch.rpm Wrote: /builddir/build/RPMS/rust-tokenizers+onig-devel-0.21.4-1.fc43.noarch.rpm Wrote: /builddir/build/RPMS/rust-tokenizers+progressbar-devel-0.21.4-1.fc43.noarch.rpm Wrote: /builddir/build/RPMS/rust-tokenizers-devel-0.21.4-1.fc43.noarch.rpm RPM build warnings: File listed twice: /usr/share/cargo/registry/tokenizers-0.21.4/CHANGELOG.md File listed twice: /usr/share/cargo/registry/tokenizers-0.21.4/LICENSE File listed twice: /usr/share/cargo/registry/tokenizers-0.21.4/README.md -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2358553 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202358553%23c7 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
