https://bugzilla.redhat.com/show_bug.cgi?id=2398191

Mikel Olasagasti Uranga <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]
             Status|NEW                         |ASSIGNED
           Assignee|[email protected]    |[email protected]



--- Comment #3 from Mikel Olasagasti Uranga <[email protected]> ---
> Patch0:         checkmake-0.2.2-remove-git-from-makefile.patch
> (...)
> make

You could just skip this and export GO_LDFLAGS and use regular %gobuild.
Something like:

export GO_LDFLAGS="-X main.version=%{version} \
                   -X main.buildTime=$(date -u -d@$SOURCE_DATE_EPOCH
+"%Y-%m-%dT%H:%M:%SZ") \
                   -X main.builder=Fedora"
%gobuild -o %{gobuilddir}/bin/checkmake ./cmd/checkmake

The main.goversion GO_LDFLAG would be missing in that proposal, but I don't
have time at the moment to check the correct way to set it.

You would miss the pandoc part, but would to manually run this Makefile rule:

%.1: man/man1/%.1.md
        sed "s/REPLACE_DATE/$(BUILDDATE)/" $< | pandoc -s -t man -o $@

> %doc man/man1/checkmake.1.md

If you require pandoc to create the manpage, it would make sense to install it
and not the md file


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2398191

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202398191%23c3

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to