https://bugzilla.redhat.com/show_bug.cgi?id=2397174
Petr Pisar <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #2 from Petr Pisar <[email protected]> --- URL and Source0 addresses are usable. Ok. TODO: Use https://cpan.metacpan.org/authors/id/B/BI/BIGPRESH/Data-Censor-%{version}.tar.gz as Sourc0 URL. Source0 archive (SHA512: de24ec34f4f433795b2cbb0a5ff6191a972f4f9684964a3f442e75588c3a634a66734983d5d9b3c7f43a5470aa1dd278fba7360a84b23eec9885e0133fd5c51d) is original. Ok. Licenses verified in README, lib/Data/Censor.pm, and Makefile.PL. Ok. Summary verified in lib/Data/Censor.pm. Ok. Description is Ok. No XS code, noarch BuildArch is Ok. Build dependencies are Ok. TODO: Unset RELEASE_TESTING environment variable in %check phase to make the tests more reproducible (t/manifest.t:7). All tests pass. Ok. $ rpmlint perl-Data-Censor.spec ../SRPMS/perl-Data-Censor-0.04-1.fc44.src.rpm ../RPMS/noarch/perl-Data-Censor-0.04-1.fc44.noarch.rpm ======================================== rpmlint session starts ======================================= rpmlint: 2.7.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 === 2 packages and 1 specfiles checked; 0 errors, 0 warnings, 6 filtered, 0 badness; has taken 0.3 s == rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Data-Censor-0.04-1.fc44.noarch.rpm drwxr-xr-x 2 root root 0 Sep 21 02:00 /usr/share/doc/perl-Data-Censor -rw-r--r-- 1 root root 420 Jun 19 10:40 /usr/share/doc/perl-Data-Censor/Changes -rw-r--r-- 1 root root 5665 Mar 12 2014 /usr/share/doc/perl-Data-Censor/README -rw-r--r-- 1 root root 3280 Sep 21 02:00 /usr/share/man/man3/Data::Censor.3pm.gz drwxr-xr-x 2 root root 0 Sep 21 02:00 /usr/share/perl5/vendor_perl/Data -rw-r--r-- 1 root root 8152 Jun 19 10:38 /usr/share/perl5/vendor_perl/Data/Censor.pm File layout an permission are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Data-Censor-0.04-1.fc44.noarch.rpm | sort -f | uniq -c 1 perl(:VERSION) >= 5.6.0 1 perl(Carp) 1 perl(Ref::Util) 1 perl(strict) 1 perl(warnings) 1 perl-libs 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Data-Censor-0.04-1.fc44.noarch.rpm | sort -f | uniq -c 1 perl(Data::Censor) = 0.04 1 perl-Data-Censor = 0.04-1.fc44 Binary provides are Ok. $ resolvedeps f44-build ../RPMS/noarch/perl-Data-Censor-0.04-1.fc44.noarch.rpm Binary dependencies are resolvable. Ok. The package builds in Rawhide (https://koji.fedoraproject.org/koji/taskinfo?taskID=137491554). Ok. The package is in line with Fedora and Perl packaging guidelines. Please consider fixing the TODO items before building this package. This package is APPROVED. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2397174 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202397174%23c2 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
