https://bugzilla.redhat.com/show_bug.cgi?id=2262694
--- Comment #69 from Luya Tshimbalanga <[email protected]> --- (In reply to Jonathan Steffan from comment #68) > [!]: Development (unversioned) .so files in -devel subpackage, if present. > Note: Unversioned so-files in private %_libdir subdirectory (see > attachment). Verify they are not in ld path. > > /usr/share/materialx/stdlib/genosl/include seems like it should be in -devel? Logically it should but the path is on %{_datadir} suggesting an example. > > [!]: License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. Licenses > found: "Unknown or generated", "*No copyright* Apache License 2.0", > "BSD 3-Clause License", "*No copyright* Apache License", "Apache > License 2.0", "MIT License", "*No copyright* Apache License 2.0 and/or > ISC License and/or MIT License", "*No copyright* ISC License", "*No > copyright* ISC License and/or MIT License", "Apache License 2.0 and/or > BSD 3-Clause License", "zlib License", "*No copyright* MIT License", > "MIT License and/or The Unlicense", "Apache License 2.0 and/or Khronos > License and/or MIT License", "Khronos License", "*No copyright* Boost > Software License 1.0", "Boost Software License 1.0", "Simple Public > License and/or zlib License". 692 files have unknown license. Detailed > output of licensecheck in /home/jon/Reviews/materialx/licensecheck.txt > [!]: License file installed when any subpackage combination is installed. > [!]: If the package is under multiple licenses, the licensing breakdown > must be documented in the spec. > > Add licensing breakdown on a path basis. Ensure that full copies of all > licenses are included. > > [!]: Package requires other packages for directories it uses. > Note: No known owner of /usr/share/licenses/materialx > [!]: Package must own all directories that it creates. > Note: Directories without known owners: /usr/share/licenses/materialx, > /usr/lib/python3.14, /usr/lib/python3.14/site-packages Will fix. > > Related to licensing. I'm not sure if all you need to do here is %dir > /usr/share/licenses/%{name}... > Or %{_licensedir} in this case. > > [!]: Package does not own files or directories owned by other packages. > Note: Dirs in package are owned also by: /usr/lib/python3.14/site- > packages/materialx(python3-mkdocs-material-extensions), > /usr/lib/python3.14/site- > packages/materialx/__pycache__(python3-mkdocs-material-extensions) > > This seems like an odd directory to me. > > [!]: Package contains no bundled libraries without FPC exception. > > Noting the bundled(nanogui). Default it's not built. > > > [!]: Package contains desktop file if it is a GUI application. > > It seems like it'd be better to generate the .desktop files and check them > into distgit vs always generating them. Should they be contributed upstream? > > [!]: Development files must be in a -devel package > > /usr/share/materialx/stdlib/genosl/include > > [!]: Useful -debuginfo package or justification otherwise. > > Change the build target to: -DCMAKE_BUILD_TYPE=RelWithDebInfo > > [!]: If the source package does not include license text(s) as a separate > file from upstream, the packager SHOULD query upstream to include it. > > Seems like we are missing some license files? > > [!]: Fully versioned dependency in subpackages if applicable. > Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in > materialx-devel > > This also affects if licenses are installed with any subpackage combination. > > [!]: %check is present and all tests pass. > > Is there a reason we are not building and running the tests? > > [!]: Packages should try to preserve timestamps of original installed > files. > > Add -p to your `install` usage. > > > > python3-materialx.x86_64: E: non-executable-script /usr/bin/baketextures.py > 644 /usr/bin/env python > python3-materialx.x86_64: E: non-executable-script > /usr/bin/creatematerial.py 644 /usr/bin/env python > python3-materialx.x86_64: E: non-executable-script > /usr/bin/generateshader.py 644 /usr/bin/env python > python3-materialx.x86_64: E: non-executable-script /usr/bin/genmdl.py 644 > /usr/bin/env python > python3-materialx.x86_64: E: non-executable-script /usr/bin/mxdoc.py 644 > /usr/bin/env python > python3-materialx.x86_64: E: non-executable-script /usr/bin/mxformat.py 644 > /usr/bin/env python > python3-materialx.x86_64: E: non-executable-script /usr/bin/mxvalidate.py > 644 /usr/bin/env python > python3-materialx.x86_64: E: non-executable-script > /usr/bin/translateshader.py 644 /usr/bin/env python > python3-materialx.x86_64: E: non-executable-script > /usr/bin/writenodegraphs.py 644 /usr/bin/env python > python3-materialx.x86_64: E: non-executable-script > /usr/lib/python3.14/site-packages/materialx/colorspace.py 644 /usr/bin/env > python > python3-materialx.x86_64: E: non-executable-script > /usr/lib/python3.14/site-packages/materialx/datatype.py 644 /usr/bin/env > python > python3-materialx.x86_64: E: non-executable-script > /usr/lib/python3.14/site-packages/materialx/main.py 644 /usr/bin/env python > python3-materialx.x86_64: W: non-executable-in-bin /usr/bin/baketextures.py > 644 > python3-materialx.x86_64: W: non-executable-in-bin > /usr/bin/creatematerial.py 644 > python3-materialx.x86_64: W: non-executable-in-bin > /usr/bin/generateshader.py 644 > python3-materialx.x86_64: W: non-executable-in-bin /usr/bin/genmdl.py 644 > python3-materialx.x86_64: W: non-executable-in-bin /usr/bin/mxdoc.py 644 > python3-materialx.x86_64: W: non-executable-in-bin /usr/bin/mxformat.py 644 > python3-materialx.x86_64: W: non-executable-in-bin /usr/bin/mxvalidate.py 644 > python3-materialx.x86_64: W: non-executable-in-bin > /usr/bin/translateshader.py 644 > python3-materialx.x86_64: W: non-executable-in-bin > /usr/bin/writenodegraphs.py 644 > python3-materialx.x86_64: E: env-script-interpreter /usr/bin/baketextures.py > /usr/bin/env python > python3-materialx.x86_64: E: env-script-interpreter > /usr/bin/creatematerial.py /usr/bin/env python > python3-materialx.x86_64: E: env-script-interpreter > /usr/bin/generateshader.py /usr/bin/env python > python3-materialx.x86_64: E: env-script-interpreter /usr/bin/genmdl.py > /usr/bin/env python > python3-materialx.x86_64: E: env-script-interpreter /usr/bin/mxdoc.py > /usr/bin/env python > python3-materialx.x86_64: E: env-script-interpreter /usr/bin/mxformat.py > /usr/bin/env python > python3-materialx.x86_64: E: env-script-interpreter /usr/bin/mxvalidate.py > /usr/bin/env python > python3-materialx.x86_64: E: env-script-interpreter > /usr/bin/translateshader.py /usr/bin/env python > python3-materialx.x86_64: E: env-script-interpreter > /usr/bin/writenodegraphs.py /usr/bin/env python > > All of these needs to be addressed. > I'm not sure if it's best to just remove the ones in /usr/bin? > Rename them? (i.e. /usr/bin/baketextures.py -> > /usr/bin/materialx-baketextures). > I don't think we should ship them as baketextures.py, etc. Will fix. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2262694 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202262694%23c69 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
