https://bugzilla.redhat.com/show_bug.cgi?id=2397031
--- Comment #3 from Jeremy Cline <[email protected]> --- This spec is very much aligned with dotnet9.0 so nothing there's no huge issues here, just a bit of cruft that's accumulated: - in the "%if ( 0%{?fedora} && 0%{?fedora} < 38 ) || ( 0%{?rhel} && 0%{?rhel} < 9 )" macro you could drop the Fedora bit since f38 is very dead at this point. I'm not sure if you plan to build this for EPEL/RHEL9, but if not it'd be nice to clean up that whole block. - The bundled brotli version is v1.1.0 and the "Provides: bundled(libbrotli) = 1.0.9" statement should be updated accordingly - the bundled libunwind version is now v1.8.0 and its version file is at src/runtime/src/native/external/libunwind-version.txt - inside the check section there's a "%if 0%{?fedora} > 35" block which could be cleaned up now that Fedora 35 is no more. There's a similar check for less than 38 just below it that could be dropped - I see there's options to bundle rapidjson, llvm-libunwind, and zlib-ng but no corresponding provides for the bundled versions. The only real issue is the last one, and for Fedora it's only an issue with llvm-libunwind since the rest are set to use system libraries. For RHEL there's "use_bundled_rapidjson 1" so it'd be good to add all of them to align with the available knobs to bundle (or not) the various libraries. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2397031 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202397031%23c3 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
