https://bugzilla.redhat.com/show_bug.cgi?id=2334587



--- Comment #13 from [email protected] ---
Spec URL: https://trix.fedorapeople.org/migraphx.spec
SRPM URL: https://trix.fedorapeople.org/migraphx-7.0.1-1.fc44.src.rpm

- Sorry for the delay, but looks like 7.0.1 is out, so it needs to be refreshed

%global rocm_release 7.0
%global rocm_patch 1

- Bundled(llvm-project) should actually break down the llvm subcomponents. E.g.
if it bundles libllvm and libclang as a static lib, you need two lines
specifying bundled(llvm) and bundled(clang)

%global bundled_llvm_version 21.0.0
# rocMLIR bundles a fork of rocm-llvm which itself is a fork of the upstream
llvm
Provides:       bundled(llvm) = %bundled_llvm_version
Provides:       bundled(clang) = %bundled_llvm_version

- As well, since it bundles rocMLIR, maybe we should add that provides too? Not
sure honestly, but might be good to add just in case.

From this issue
https://github.com/ROCm/rocMLIR/issues/1713
rocMLIR is never intended to be built as a stand alone project.

- Is mlir-hal a bundle? It's not clear if this is a community project that was
just thrown into the rocMLIR tree. It's not very clear why it's in externals

# external/mlir-hal/CMakesLists.txt comes from
# Merge: 11d3f3f571aa 743bfaa4540c
# Author: SJW <[email protected]>
# Date:   Tue Jun 20 18:59:07 2023 +0000
#
#    Add 'external/mlir-hal/' from commit
'743bfaa4540cd124a260643b308f0dac3fceedd9'
#
# This is commit in the same rocMLIR project, so this is confusing, open this
ticket
# suggesting a move from external/mlir-hal to mlir-hal
# https://github.com/ROCm/rocMLIR/issues/2026

- License break down is needed in the spec

A lot of documenting the false positives. The licenses all have license files.
# LICENSE : MIT
# AMDMIGraphX, the main project
#
# LICENSE.rocMLIR.TXT : Apache-2.0 WITH LLVM-exception OR NCSA
# 
# LICENSE.llvm-project.TXT : Apache-2.0 WITH LLVM-exception OR NCSA
# rocMLIR/external/llvm-project/*


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2334587

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202334587%23c13

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to