https://bugzilla.redhat.com/show_bug.cgi?id=2359607
--- Comment #2 from Petr Pisar <[email protected]> --- URL and Source addresses are usable. Ok. Source0 archive (SHA-512: b5a86e940b620838545ab336a6d8888ffd6d483203d715e7903d8d14a75bc126aba030dead3b16fb0ee35b37941dfc5f9569af0786114906d9062ea030255b9c) is original. Ok. Summary verified from README.md. Ok. Description verified from README.md. Ok. Found licenses: BSD-3-Clause: deps/hiredis/ssl.c GPL-1.0-or-later OR Artistic-1.0-Perl: lib/Redis/Fast.pm FIX: Declare the BSD-3-Clause license in the License tag and package deps/hiredis/COPYING with %license macro. FIX: Provide 'bundled(hiredis) = 1.2.0' Or unbundle ./deps/hiredis. FIX: Build-require 'perl-devel' for building XS files. FIX: Build-require 'perl(ExtUtils::CBuilder)' for Building XS files with Module::Build. FIX: Build-require 'make' (builder/MyBuilder.pm:49). FIX: Build-require 'grep' (deps/hiredis/Makefile:12). FIX: Build-require 'gawk' (deps/hiredis/Makefile:12). FIX: Build-require 'gcc' (deps/hiredis/Makefile:39). TODO: Constrain 'perl(Module::Build::XSUtil)' with '>= 0.02' (META.json:34). TODO: Move 'perl(File::Temp)' to Tests section (t/tlib/Test/SpawnRedisServer.pm:7). TODO: Move 'perl(Parallel::ForkManager)' to Tests section (t/02-responses.t:11). FIX: Remove 'perl(Module::Build)' build-dependency. It's not used directly. FIX: Build-require 'perl(POSIX)' (t/11-timeout.t:11). FIX: Build-require 'findutils' (perl-Redis-Fast.spec:71). All tests pass. Ok. TODO: Unset USE_SSL, REDIS_SERVER, REDIS_SERVER_PATH, REDIS_DEBUG, TEST_REDIS_SERVER_SOCK_PATH environment variables ib %check section to make the tests more deterministic. $ rpmlint perl-Redis-Fast.spec ../SRPMS/perl-Redis-Fast-0.37-1.fc44.src.rpm ../RPMS/x86_64/perl-Redis-Fast-* ======================================== rpmlint session starts ======================================= rpmlint: 2.7.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 5 perl-Redis-Fast.x86_64: E: spelling-error ('hiredis', '%description -l en_US hiredis -> hire dis, hire-dis, hired is') perl-Redis-Fast.src: E: spelling-error ('hiredis', '%description -l en_US hiredis -> hire dis, hire-dis, hired is') perl-Redis-Fast.x86_64: E: incorrect-fsf-address /usr/share/licenses/perl-Redis-Fast/LICENSE == 4 packages and 1 specfiles checked; 3 errors, 0 warnings, 13 filtered, 3 badness; has taken 0.7 s == rpmlint is Ok. FIX: The package does not build in Fedora Rawhide (https://koji.fedoraproject.org/koji/taskinfo?taskID=138166916). It fails on i686: nothing provides valkey = 8.1.4-2.fc44 needed by valkey-compat-redis-8.1.4-2.fc44.noarch $ rpm -q -lv -p ../RPMS/x86_64/perl-Redis-Fast-0.37-1.fc44.x86_64.rpm drwxr-xr-x 2 root root 0 Apr 14 2025 /usr/lib/.build-id drwxr-xr-x 2 root root 0 Apr 14 2025 /usr/lib/.build-id/7c lrwxrwxrwx 1 root root 63 Apr 14 2025 /usr/lib/.build-id/7c/8ad16d10acafe81cd35e2fca92ea1cc34a1637 -> ../../../../usr/lib64/perl5/vendor_perl/auto/Redis/Fast/Fast.so drwxr-xr-x 2 root root 0 Apr 14 2025 /usr/lib64/perl5/vendor_perl/Redis drwxr-xr-x 2 root root 0 Apr 14 2025 /usr/lib64/perl5/vendor_perl/Redis/Fast -rw-r--r-- 1 root root 23097 Apr 14 2025 /usr/lib64/perl5/vendor_perl/Redis/Fast.pm -rw-r--r-- 1 root root 2129 Apr 14 2025 /usr/lib64/perl5/vendor_perl/Redis/Fast/Hash.pm -rw-r--r-- 1 root root 1900 Apr 14 2025 /usr/lib64/perl5/vendor_perl/Redis/Fast/List.pm -rw-r--r-- 1 root root 1809 Apr 14 2025 /usr/lib64/perl5/vendor_perl/Redis/Fast/Sentinel.pm drwxr-xr-x 2 root root 0 Apr 14 2025 /usr/lib64/perl5/vendor_perl/auto/Redis drwxr-xr-x 2 root root 0 Apr 14 2025 /usr/lib64/perl5/vendor_perl/auto/Redis/Fast -rwxr-xr-x 1 root root 144936 Apr 14 2025 /usr/lib64/perl5/vendor_perl/auto/Redis/Fast/Fast.so drwxr-xr-x 2 root root 0 Apr 14 2025 /usr/share/doc/perl-Redis-Fast -rw-r--r-- 1 root root 4594 Mar 8 2024 /usr/share/doc/perl-Redis-Fast/Changes -rw-r--r-- 1 root root 8589 Mar 8 2024 /usr/share/doc/perl-Redis-Fast/README.md drwxr-xr-x 2 root root 0 Apr 14 2025 /usr/share/licenses/perl-Redis-Fast -rw-r--r-- 1 root root 18421 Mar 8 2024 /usr/share/licenses/perl-Redis-Fast/LICENSE -rw-r--r-- 1 root root 4062 Apr 14 2025 /usr/share/man/man3/Redis::Fast.3pm.gz -rw-r--r-- 1 root root 1242 Apr 14 2025 /usr/share/man/man3/Redis::Fast::Hash.3pm.gz -rw-r--r-- 1 root root 1095 Apr 14 2025 /usr/share/man/man3/Redis::Fast::List.3pm.gz -rw-r--r-- 1 root root 1430 Apr 14 2025 /usr/share/man/man3/Redis::Fast::Sentinel.3pm.gz FIX: Package deps/hiredis/COPYING with %license macro. $ rpm -q --requires -p ../RPMS/x86_64/perl-Redis-Fast-0.37-1.fc44.x86_64.rpm | sort -g | uniq -c 1 libcrypto.so.3()(64bit) 1 libcrypto.so.3(OPENSSL_3.0.0)(64bit) 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.14)(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.3.4)(64bit) 1 libc.so.6(GLIBC_2.3)(64bit) 1 libc.so.6(GLIBC_2.4)(64bit) 1 libc.so.6(GLIBC_ABI_DT_RELR)(64bit) 1 libc.so.6(GLIBC_ABI_GNU2_TLS)(64bit) 1 libssl.so.3()(64bit) 1 libssl.so.3(OPENSSL_3.0.0)(64bit) 1 perl(base) 1 perl(Carp) 1 perl(constant) 1 perl(Encode) 1 perl-libs 1 perl(:MODULE_COMPAT_5.42.0) 1 perl(Redis::Fast) 1 perl(Redis::Fast::Sentinel) 1 perl(Scalar::Util) 1 perl(strict) 1 perl(Tie::Array) 1 perl(Tie::Hash) 1 perl(Try::Tiny) 1 perl(warnings) 1 perl(XSLoader) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 1 rtld(GNU_HASH) Run-time 'perl(IO::Socket::SSL)' dependency is optional. Ok. Binary requires are Ok. $ rpm -q --provides -p ../RPMS/x86_64/perl-Redis-Fast-0.37-1.fc44.x86_64.rpm | sort -g | uniq -c 1 perl(Redis::Fast) = 0.37 1 perl-Redis-Fast = 0.37-1.fc44 1 perl(Redis::Fast::Hash) 1 perl(Redis::Fast::List) 1 perl(Redis::Fast::Sentinel) 1 perl-Redis-Fast(x86-64) = 0.37-1.fc44 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/x86_64/perl-Redis-Fast-0.37-1.fc44.x86_64.rpm Binary dependencies are resolvable. Ok. Otherwise, the package is in line with Fedora and Perl packaging guidelines. Please correct the FIX items, consider fixing TODO items, and provide an updated spec file. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2359607 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202359607%23c2 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
