https://bugzilla.redhat.com/show_bug.cgi?id=2394793



--- Comment #3 from Ben Beasley <[email protected]> ---
Thank you for the review!

https://release-monitoring.org/project/256591/

(In reply to Benson Muite from comment #2)
> Comments:
> a) Please own documentation directories

Oops! Thank you. I’ll fix that on import.

> b) Everything else seems ok, newest python packaging macros are not fully
> supported,
> hence the python3-devel warning.
> c) Two copies of the license file are packaged:
>  /usr/lib/python3.14/site-packages/cucumber_expressions-18.0.1.dist-info/
> LICENSE
>  /usr/share/licenses/python3-cucumber-expressions/LICENSE
> but only one has metadata:
>  rpm -qL python3-cucumber-expressions-18.0.1-1.fc44.noarch.rpm
> /usr/share/licenses/python3-cucumber-expressions/LICENSE
> so this is ok, poetry seems not to recognize the metadata even with:
> https://github.com/cucumber/cucumber-expressions/pull/361
> applied.

Yes, this duplication of license files is the standard situation for
poetry-core and a few other build backends that don’t yet have proper PEP 639
support yet. It’s far too fussy to try to add %license to the .dist-info
license file(s) manually simply to avoid duplication of a small license file.
There are fewer and fewer build backends that don’t have PEP 639 support,
fortunately, and based on https://github.com/python-poetry/poetry/pull/10413
I’m hoping that even poetry may catch up once we have release 2.2.0 packaged.

> d) Approved. Please fix (a) before import.

Thank you! I will.

> e) Review of:
> https://bugzilla.redhat.com/show_bug.cgi?id=2399980
> would be appreciated if time allows.

Reviewed.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2394793

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202394793%23c3

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to