https://bugzilla.redhat.com/show_bug.cgi?id=2373124
--- Comment #19 from Göran Uddeborg <[email protected]> --- Thanks again for your continued review! In reply to your comments: a) Nothing to do here, right? b) Here I'm confused. portsentry-fail2ban DOES already require the main package. What is it I'm missing? c) I didn't think the documentation was big enough for a separate doc package, but I don't mind making one if you think so. A "recommends" from the main package is appropriate, don't you think? (I did not include the manual pages in the doc subpackage, that doesn't seem to be how others do it.) first (☺) d) Good catch. (I obviously need look closer at the output of "licensecheck"!) first e) I've suggested it upstreams: https://github.com/portsentry/portsentry/issues/173 second d) As far as I can understand it should be ok. I'm testing it and don't see any immediate problems. I've suggested that too upstreams: https://github.com/portsentry/portsentry/issues/174 second e) Here again I'm confused. The log file lives directly in /var/log, owned by "fileystem". That is one of the explicit exceptions where a package should not own the directory. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_and_directory_ownership No other package except for "filesystem" owns /var/log. Spec URL: https://www.uddeborg.se/portsentry/portsentry-2.0.5-2.spec SRPM URL: https://www.uddeborg.se/portsentry/portsentry-2.0.5-2.fc43.src.rpm Binary URLs: https://www.uddeborg.se/portsentry/portsentry-2.0.5-2.fc43.x86_64.rpm https://www.uddeborg.se/portsentry/portsentry-doc-2.0.5-2.fc43.noarch.rpm https://www.uddeborg.se/portsentry/portsentry-fail2ban-2.0.5-2.fc43.noarch.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2373124 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202373124%23c19 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
