Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=688183 Fabian Affolter <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #7 from Fabian Affolter <[email protected]> 2011-04-02 10:13:24 EDT --- Just some comments on your spec file: - The description is too long. Do not exceed 80 characters per line. I think that rpmlint will complain about that anyway. - Check https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files for details about installation of .desktop files. - There are some typos in the .desktop files. And nobody cares where a piece of software is coming from. The .desktop files points to an icon but your are not installing the icon in your spec file. - The update of the desktop database is missing, see https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-database - Isn't RPM picking the Requires: automatically? - The "Vendor:" tag is not needed. - The "Release:" tag should contain the release of the spec file. Please check https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Package_Version for details. I strongly suggest that you read the Fedora Packaging guidelines. https://fedoraproject.org/wiki/Packaging:Guidelines -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
