https://bugzilla.redhat.com/show_bug.cgi?id=2401019
Neal Gompa <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #3 from Neal Gompa <[email protected]> --- Some drive-by comments of the spec: > Source: ukiboot-%{version}.tar.xz Where does it come from? There's no URL and Source lacks a SourceURL. > %global gnu_efi_builddep gnu-efi-devel This macro makes no sense and should be dropped. > {?gnu_efi_options} What is supposed to define this macro? > %{efi_esp_dir}/* Why are we directly installing into /boot/efi? I thought we are trying to avoid that nowadays... Also, even if we are, since this isn't a package-specific namespace, this glob is too greedy. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2401019 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202401019%23c3 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
