https://bugzilla.redhat.com/show_bug.cgi?id=2395215
--- Comment #7 from John Whitington <[email protected]> --- Spec URL: https://coherentpdf.com/fedora2/ocaml-cpdf.spec Patch file: https://coherentpdf.com/fedora2/patch.patch SRPM URL: https://coherentpdf.com/fedora2/ocaml-cpdf-2.8.1-1.fc41.src.rpm Thanks Jerry. ===== Issues ===== - The files cpdfunicodedata* seem to be under the Unicode-DFS-2015 license. That does not appear in the License tag (nor in README.md, I might add, where the other licenses are listed). Done in the spec file, and fixed upstream ready for the next version. - Please replace all occurrences of /usr/bin with %{_bindir}, and all occurrences of /usr/share/man with %{_mandir}. See https://docs.fedoraproject.org/en-US/packaging-guidelines/RPMMacros/#macros_installation Done. - In %files for cpdf, do not specify the .gz suffix for the man page. Fedora currently uses gzip to compress man pages, but may change that at some future date. Use a glob there instead: %{_mandir}/man1/cpdf.1* See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages Done. - Do I understand correctly that cpdfyojson.* is a bundled version of ocaml-yojson, and cpdfxmlm.* is a bundled version of ocaml-xmlm? If so, can they be unbundled? If not, then appropriate "Provided: bundled(foo)" lines must be added to the spec file, and I personally would prefer to see a comment in the spec file explaining why they can't be unbundled. See https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling Yes, but they are old versions and have been modified for Cpdf. I have a number of hygiene changes to make for Cpdf 3.0 next year, and I'll try to make sure regularizing this is among them. - Note the description-shorter-than-summary warnings below from rpmlint. The Summary should be a short description of the package; %description should be a full description. If %summary is longer than %description, something is wrong. Thanks for the explanation. Done. - %check is empty. Is there anything that could be done there, some manipulation of one of the includes PDF files perhaps, just to verify that it runs at all? Done. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2395215 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202395215%23c7 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
