https://bugzilla.redhat.com/show_bug.cgi?id=2404364



--- Comment #5 from Benson Muite <[email protected]> ---


> 
> 
> a( Can you add a comment about these lines:
> 
>  Provides: openarm_can = %{version}
>  Obsoletes: openarm_can <= 1.1.0
> 

Needed to ensure if someone uses old package name, it can be found. See
https://docs.fedoraproject.org/en-US/packaging-guidelines/#renaming-or-replacing-existing-packages

> b) Also fix alignment with lines above.
>

Ok

> c) Should -utils have:
> 
>  Requires:  %{name}%{?_isa} = %{version}-%{release}
> 
> or is auto generated .so deps good enough?
>

These are scripts.  They do not need the .so files.

> d) the 1.1.0 release is just 10 days, still a newer git hash is required,
> why?

This allows obsoleting of the previous package, a better installation process
for the utility scripts and to test packit for the automatic upgrade process.


spec: https://fed500.fedorapeople.org/openarm-can.spec
srpm:
https://fed500.fedorapeople.org/openarm-can-1.1.0%5e20251016git010ea25-1.fc42.src.rpm


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2404364

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202404364%23c5

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to