https://bugzilla.redhat.com/show_bug.cgi?id=2369164
--- Comment #6 from Andrew Bauer <[email protected]> --- I tried twice previously to follow up with this when work got in the way. Let's try the third time.... I did some testing with mock and the runtime requirement for cups really is needed. Without the cups requirement, the package installs but there is no good way to add a printer to the system without the cups frontend. Realistically, will this package ever get installed on a machine that does not already have cups package installed? Probably not, but I'd prefer to keep the requirement in there for completeness. I added the python3-cups buildrequires to the original dymo-cups-drivers in 2019, no doubt to solve some kind of build problem, but I can't for life of me determine why. This project does not use python at all. This buildrequirement has been removed. I made a note to revisit dymo-cups-drivers package after this review. Lastly, because the end user is not using github for version control, my argument is this does not qualify as a postrelease. Taken from the documentation linked earlier: > Snapshots (a version taken from the upstream source control system not > associated with a release) The version used in this package *IS* associated with the 2.0.0.0 release. Consequently, adding the git commit to the release tag would incorrectly imply this packages has commits newer than the 2.0.0.0 release. I have completed some of the optional changes: - removed COPYING - removed glibc-headers buildrequires I will not make these changes: - add VCS - doesn't apply here since upstream is not using github for version control - autochangelog macro - Never going to use these. - Prefer to keep my sources and patches numbered - Will leave the sed buildrequires. I have been asked to add it in previous packages reviews (from years ago). Today it might not be needed, but all it takes is someone who wants to shrink a buildroot smaller and suddenly we will have to call this out. updated Spec URL: https://download.copr.fedorainfracloud.org/results/kni/dymo-cups-drivers/fedora-rawhide-x86_64/09716005-dymo-cups-drivers-lw5xx/dymo-cups-drivers-lw5xx.spec Updated URL: https://download.copr.fedorainfracloud.org/results/kni/dymo-cups-drivers/fedora-rawhide-x86_64/09716005-dymo-cups-drivers-lw5xx/dymo-cups-drivers-lw5xx-2.0.0.0-1.fc44.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2369164 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202369164%23c6 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
