https://bugzilla.redhat.com/show_bug.cgi?id=2406317
--- Comment #4 from Ben Beasley <[email protected]> --- Thank you for the review! (In reply to Terje Rosten from comment #3) > Summary: > > - issue: spec don't include python3-devel, that's due to need style > BuildSystem: pyproject ? Correct, "BuildSystem: pyproject" implies a dependency on python3-devel, so the explicit "BuildRequires: python3-devel" is not needed. In fact, even just using "%pyproject_buildrequires" should suffice; see https://pagure.io/packaging-committee/pull-request/1379. > - missing %check, even here is some logic regarding pytest present, > will the new BuildSystem stuff run tests without any code in %check? You can read the "Provisional: Declarative Buildsystem (RPM 4.20+)" section at https://src.fedoraproject.org/rpms/pyproject-rpm-macros to see how this works. The pyproject declarative buildsystem is generating sections like this: %prep %autosetup -p1 -C %generate_buildrequires %pyproject_buildrequires %build %pyproject_wheel %install %pyproject_install %pyproject_save_files <options from BuildOption(install)> %check %pyproject_check_import You’re right that I’ve made an error here in failing to actually run the tests. Only the "%pyproject_check_import" smoke test happens implicitly. The solution is to add: %check -a %pytest -v However, I also ran into an undeclared test dependency on typing-extensions and filed an upstream PR, https://github.com/fastapi/annotated-doc/pull/12, which I’ll apply as a patch. I’ll upload a new submission shortly. Thanks for catching this! -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2406317 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202406317%23c4 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
