https://bugzilla.redhat.com/show_bug.cgi?id=2406371
--- Comment #3 from Aleksei Bavshin <[email protected]> --- Spec URL: https://alebastr.fedorapeople.org/review/nghttp3/nghttp3.spec SRPM URL: https://alebastr.fedorapeople.org/review/nghttp3/nghttp3-1.12.0-1.fc43.src.rpm (In reply to Terje Rosten from comment #2) > Some comments: > > a) > URL: https://nghttp2.org/nghttp3/ > this contains docs only, better to use github url here? Technically, URL field should point to the upstream project's website and https://nghttp2.org/nghttp3/ is the official website. Although, as you noted, GitHub URL is more informative. Applied. > > b) > > %build > autoreconf -fiv > > Why is autoreconf needed? It's not needed per se, but has some benefits. Debian policy recommends to autoreconf on build, see https://wiki.debian.org/Autoreconf for the rationale, and there were several attempts to introduce a similar policy in Fedora. Most recently this was recently discussed in https://lists.fedoraproject.org/archives/list/[email protected]/thread/URIOGXSIURJGTAGYCBJ5CD7FM47DXRKR/ and https://lists.fedoraproject.org/archives/list/[email protected]/thread/URIOGXSIURJGTAGYCBJ5CD7FM47DXRKR/#LGNSVJXVEXNIMIBLW7ETGB3C6Y5JCW7X > c) > find %{buildroot} -name '*.la' -exec rm -f {} ';' > > simpler to use -delete option? > > find %{buildroot} -name '*.la' -delete `-delete` is a GNU extension, and I prefer POSIX syntax. Also, this line is taken as is from the default spec template. > > d) just drop use of %name macro? E.g. this is not very readable: > > %files -n lib%{name} Makes sense. Done. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2406371 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202406371%23c3 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
