https://bugzilla.redhat.com/show_bug.cgi?id=2406063

Terje Rosten <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #2 from Terje Rosten <[email protected]> ---
> License:        MIT

License seems to be some BSD variant, not MIT?

> URL:            https://pypi.org/project/ana/

Use github url https://github.com/zardus/ana here, seems more useful.


> BuildRequires:  python3-devel
> BuildRequires:  python3-setuptools

Move these to top level package (below BuildArch:      noarch line)
and consider to remove python3-setuptools, likely not needed.

> %{?python_provide:%python_provide python3-%{pypi_name}}

This is legacy cruft and should be removed now I think

> Patch:          https://github.com/zardus/ana/pull/17.patch

Add line about what the patch does.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2406063

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202406063%23c2

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to