https://bugzilla.redhat.com/show_bug.cgi?id=2402462
Terje Rosten <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|[email protected] |[email protected] Flags| |fedora-review? CC| |[email protected] --- Comment #2 from Terje Rosten <[email protected]> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Dist tag is present. - The License field must be a valid SPDX expression. Note: Not a valid SPDX expression ' OFL-1.1'. See: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [!]: License field in the package spec file matches the actual license. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 146 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. fonts: [x]: Run fc-query on all fonts in package. [!]: Run repo-font-audit on all fonts in package. Note: Cannot find repo-font-audit, install fontpackages-tools package to make a comprehensive font review. See: url: undefined Rpmlint ------- Checking: vernon-adams-pacifico-fonts-3.010-1.fc44.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpwk9qod5u')] checks: 32, packages: 1 vernon-adams-pacifico-fonts.src: E: spelling-error ('von', '%description -l en_US von -> con, ON, on') vernon-adams-pacifico-fonts.spec:15: W: non-break-space line 15, char 21 1 packages and 0 specfiles checked; 1 errors, 1 warnings, 4 filtered, 1 badness; has taken 0.1 s Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://github.com/googlefonts/Pacifico/archive/423e7cb2b036ead2624c05197e17a83ddf5c6068/pacifico-423e7cb2b036ead2624c05197e17a83ddf5c6068.tar.gz : CHECKSUM(SHA256) this package : 5b99da41787c3f94c43837b05dc945bd1b2b7539ed159d861f231f664bf7a339 CHECKSUM(SHA256) upstream package : 5b99da41787c3f94c43837b05dc945bd1b2b7539ed159d861f231f664bf7a339 Requires -------- Provides -------- fc-query /usr/share/fonts/vernon-adams-pacifico-fonts/Pacifico-Regular.ttf Pattern has 28 elts (size 32) family: "Pacifico"(s) familylang: "en"(s) style: "Regular"(s) stylelang: "en"(s) fullname: "Pacifico Regular"(s) fullnamelang: "en"(s) slant: 0(i)(s) weight: 80(f)(s) width: 100(f)(s) foundry: "newt"(s) file: "/usr/share/fonts/vernon-adams-pacifico-fonts/Pacifico-Regular.ttf"(s) index: 0(i)(s) outline: True(s) scalable: True(s) charset: 0000: 00000000 ffffffff ffffffff 7fffffff 00000000 ffffdfff ffffffff ffffffff 0001: ffffffff ffffffff ffffffff 7fffffff 23058442 00198003 dffffff0 ff300fcf 0002: cfffffff 008fffc0 0a980000 00040000 00000000 10000000 3f0002c0 00000000 0003: 08069fdf 000361f8 00000000 00000000 00100000 10000200 00000001 00000000 0004: ffffffff ffffffff ffffffff 003c0c0c fffffc00 ffffff3f ffffffff ffffffff 0005: 3c0f0000 0000c3f0 00000000 00000000 00000000 00000000 00000000 00000000 001e: fffffeff ffffffff ffffffff ffffffff 403fffff ffffffff ffffffff 03ffffff 0020: 77180fff 06018047 80000010 00100000 00000000 37367ada 00000000 00000000 0021: 00400000 00000004 00000000 00000000 00000000 00000000 00000000 00000000 0022: 46268044 00000800 00000100 00000031 00000000 00000000 00000000 00000000 0025: 00000000 00000000 00000000 00000000 00000000 00000000 00001400 00000000 00fb: 00000006 00000000 00000000 00000000 00000000 00000000 00000000 00000000 (s) lang: aa|af|ast|av|ay|az-az|ba|bm|be|bg|bi|bin|br|bs|bua|ca|ce|ch|chm|co|cs|cv|cy|da|de|en|eo|es|et|eu|fi|fj|fo|fr|ff|fur|fy|ga|gd|gl|gn|gv|ha|ho|hr|hu|ia|ig|id|ie|ik|io|is|it|kaa|ki|kk|kl|ku-am|kum|kv|kw|ky|la|lb|lez|ln|lt|lv|mg|mh|mi|mk|mo|mt|nb|nds|nl|nn|no|nr|nso|ny|oc|om|os|pl|pt|rm|ro|ru|sah|se|sel|sh|sk|sl|sma|smj|smn|so|sq|sr|ss|st|sv|sw|tg|tk|tl|tn|tr|ts|tt|tyv|uk|uz|ve|vi|vo|vot|wa|wen|wo|xh|yap|yo|zu|an|crh|csb|fil|hsb|ht|jv|kj|ku-tr|kwm|lg|li|mn-mn|ms|na|ng|nv|pap-an|pap-aw|rn|rw|sc|sg|sn|su|ty|za|agr|ayc|bem|dsb|lij|mfe|mhr|miq|mjw|nhn|niu|sgs|szl|tpi|unm|wae|yuw(s) fontversion: 197263(i)(s) capability: "otlayout:DFLT otlayout:cyrl otlayout:grek otlayout:latn"(s) fontformat: "TrueType"(s) decorative: False(s) postscriptname: "Pacifico-Regular"(s) color: False(s) symbol: False(s) variable: False(s) fonthashint: True(s) order: 0(i)(s) namedinstance: False(s) fontwrapper: "SFNT"(s) Summary: a) check license b) what is the issue regardinf repo-font-audit c) fix: vernon-adams-pacifico-fonts.spec:15: W: non-break-space line 15, char 21 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2402462 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202402462%23c2 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
