https://bugzilla.redhat.com/show_bug.cgi?id=2407364



--- Comment #3 from Martin Osvald 🛹 <[email protected]> ---
Apart from the missing _isa in sub-packages' 'Requires:' (%{name}%{?_isa} =
%{version}-%{release}), it looks good!

Cosmetical stuff:

There is extra dot in the Description:

📦[mosvald@rawhide-review ~]$ rpm -qi rtrlib-doc
Name        : rtrlib-doc
Version     : 0.8.0
Release     : 1.fc44
Architecture: noarch
Install Date: Fri 31 Oct 2025 03:13:13 PM CET
Group       : Development/Libraries
Size        : 901976
License     : MIT AND Apache-2.0 AND BSD-2-Clause AND BSD-3-Clause
Signature   : (none)
Source RPM  : rtrlib-0.8.0-1.fc44.src.rpm
Build Date  : Fri 31 Oct 2025 03:09:39 PM CET
Build Host  : dynamic-2a00-1028-83a0-a846-fb63-60b3-2b7e-338c.ipv6.o2.cz
URL         : http://rpki.realmv6.org/
Summary     : Small extensible RPKI-RTR-Client C library. Documentation
Description :
RTRlib is an open-source C implementation of the  RPKI/Router Protocol
client. The library allows one to fetch and store validated prefix origin
data from a RTR-cache and performs origin verification of prefixes. It
supports different types of transport sessions (e.g., SSH, unprotected TCP)
and is easily extendable.
.  <<<=== HERE
This package contains documentation files.
📦[mosvald@rawhide-review ~]$

rpki-rov should start with capital R after the dot:

📦[mosvald@rawhide-review ~]$ rpm -qi rtr-tools
Name        : rtr-tools
Version     : 0.8.0
Release     : 1.fc44
Architecture: x86_64
Install Date: Fri 31 Oct 2025 03:13:13 PM CET
Group       : Development/Libraries
Size        : 84325
License     : MIT AND Apache-2.0 AND BSD-2-Clause AND BSD-3-Clause
Signature   : (none)
Source RPM  : rtrlib-0.8.0-1.fc44.src.rpm
Build Date  : Fri 31 Oct 2025 03:09:39 PM CET
Build Host  : dynamic-2a00-1028-83a0-a846-fb63-60b3-2b7e-338c.ipv6.o2.cz
URL         : http://rpki.realmv6.org/
Summary     : RPKI-RTR command line tools
Description :
Tools for the RTRlib
Rtrclient is command line that connects to an RPKI-RTR server and prints
protocol information and information about the fetched ROAs to the console.
rpki-rov is a command line tool that connects to an RPKI-RTR server and  
<<<=== HERE
allows to validate given IP prefixes and origin ASes.
📦[mosvald@rawhide-review ~]$


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2407364

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202407364%23c3

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to