https://bugzilla.redhat.com/show_bug.cgi?id=2411920
--- Comment #7 from Michael Schwendt <[email protected]> --- Spec URL: https://mschwendt.fedorapeople.org/libtfmxaudiodecoder.spec SRPM URL: https://mschwendt.fedorapeople.org/libtfmxaudiodecoder-1.0.0-0.2.20251104git740c78b.fc43.src.rpm > a) fix fsf address issue Fixed by the new snapshot. Github's pregenerated GPLv2 LICENSE file contained the FSF's current postal address, but rpmlint expects the web page URL instead, so the older upstream fix was insufficient. > b) a %check section with some basic tests would be nice (optional) So far there are no automated ones, which would make a difference. > c) use macros %make_* macros (optional), see prev. comment Sure. > d) split into 3 lines: BuildRequires: automake autoconf libtool and sort > buildreq (optional) Agreed. I've also replaced $RPM_BUILD_ROOT with %{buildroot} as to be more consistent with the RPM macro usage. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2411920 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202411920%23c7 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
