https://bugzilla.redhat.com/show_bug.cgi?id=2412016
--- Comment #3 from [email protected] --- Spec URL: https://trix.fedorapeople.org/rocm-origami.spec SRPM URL: https://trix.fedorapeople.org/rocm-origami-7.1.0-1.fc44.src.rpm For the update. >> - I assume rocm doesn't provide a component level tarball for this like the >> other libs? It is what it is, but I was >> confused why they didn't since they do have repo available >> (https://github.com/ROCm/origami) # Use fetch.sh to extract origami from rocm-libraries # There is no upstream origami project, it is part of the new ROCm # monorepo rocm-libraries. This monorepo is expected to replace the upstream # locations its libraries. At this time there is only a single tarball # This PR starts the process to address that # https://github.com/ROCm/rocm-libraries/pull/2494 Source1: fetch.sh >> - rpmlint complains that you misspelt "toolset" as it's actually 2 words not >> one into a tool set for **GEMM solution selection and >> - did you notify upstream about the scope problem? I don't see any bug >> report link # hipblaslt from rocm-libraries does not use cmake to find origami # https://github.com/ROCm/rocm-libraries/issues/2422 # So they would not have run into this issue. Patch1: 0001-rocm-origami-remove-scope-for-variables.patch >> - that "NOT ROCM_FOUND" sed patch you did is concerning, but not a >> blocker... I worked on other rocm components >> and it should "find" ROCM just fine when rocm-cmake is installed. Nothing done for this. >> - URL is not valid, either use >> https://github.com/ROCm/rocm-libraries/tree/develop/shared/origami, >> or I would prefer personally https://github.com/ROCm/rocm-libraries for >> simplicity URL: https://github.com/ROCm/rocm-libraries >> - The package doesn't contain a LICENSE, the develop branch does have it >> though: >> https://github.com/ROCm/rocm-libraries/commit/ea4d3de11d97a624d9348ee27e30be6346d6da10 >> Please don't forget to add this to %license later. You could cherrypick now, >> as it might resolve some of the >> ROCM_FOUND issues I mentioned above, or even a partial diff to add the file, >> so you don't forget it later # License file is not in the 7.1.0 tag, but is here Source2: https://github.com/ROCm/rocm-libraries/tree/develop/shared/origami/LICENSE.md .. %prep %autosetup -p3 -n %{upstreamname}-rocm-%{version} # The license file cp %{SOURCE2} . .. %files %doc README.md %license LICENSE.md -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2412016 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202412016%23c3 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
